Repository navigation
Conversation
…ot build Release run 42296982894: resolve ran a root `pnpm build` with no web Wasm engine, examples/spell-lab (default engine) stopped at TN_WASM_ENGINE_MISSING, and ship published nothing for 0.3.12. A ci-structure test now requires native-engine-wasm before every root `pnpm build` in any workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
It fixes the release-candidate workflow so that the 0.3.12 cohort can publish. #620 merged, but
shippublished nothing.Why does it matter?
Release run 42296982894 failed at
TN_SHIP_CANDIDATE_FAILED. The release-candidateresolvejob runs a rootpnpm buildwithout the web Wasm engine. The build includesexamples/spell-lab, which is new since 0.3.11 (#598) and runs on the default engine, so it stopped atTN_WASM_ENGINE_MISSING. Every other job in the release path that runs a root build already restores the engine first.What changed
release-candidate.yml/resolvenow runs./.github/actions/native-engine-wasmbeforepnpm build. The job timeout moves from 20 to 45 minutes, because a cache miss builds the engine with emsdk.ci-structure.spec.tshas a new test: every workflow job that runs a rootpnpm buildrestores the Wasm engine first. The test failed onrelease-candidate.yml:resolvebefore the fix and passes after it.Checks run
.github/workflowspass (972 tests).When this PR merges with a merge commit, the main push runs
ship, which publishes 0.3.12.